]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.regabi] cmd/compile: fix reporting of overflow
authorMatthew Dempsky <mdempsky@google.com>
Wed, 25 Nov 2020 05:56:47 +0000 (21:56 -0800)
committerRuss Cox <rsc@golang.org>
Wed, 25 Nov 2020 15:47:36 +0000 (15:47 +0000)
commit259fd8adbb15f2a44433c7b8b40a35e97992b345
treee7f2596897f662b68e03902c63dc6f5eb5e53d05
parent18573aea3cc5098c5c27e357e15c507a05de5599
[dev.regabi] cmd/compile: fix reporting of overflow

In the previous CL, I had incorrectly removed one of the error
messages from issue20232.go, because I thought go/constant was just
handling it. But actually the compiler was panicking in nodlit,
because it didn't handle constant.Unknown. So this CL makes it leave
n.Type == nil for unknown constant.Values.

While here, also address #42732 by making sure to report an error
message when origConst is called with an unknown constant.Value (as
can happen when multiplying two floating-point constants overflows).

Finally, add OXOR and OBITNOT to the list of operations to report
errors about, since they're also constant expressions that can produce
a constant with a greater bit length than their operands.

Fixes #42732.

Change-Id: I4a538fbae9b3ac4c553d7de5625dc0c87d9acce3
Reviewed-on: https://go-review.googlesource.com/c/go/+/272928
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/compile/internal/gc/const.go
test/const2.go
test/fixedbugs/issue20232.go