]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.regabi] cmd/compile: exporting, importing, and inlining functions with OCLOSURE
authorDan Scales <danscales@google.com>
Tue, 1 Dec 2020 22:48:03 +0000 (14:48 -0800)
committerDan Scales <danscales@google.com>
Wed, 20 Jan 2021 22:53:32 +0000 (22:53 +0000)
commit1760d736f61265b3c78a6a48f2e1904341806643
treefbf7575c435f30ae41e97589adeca569cbe0225e
parent92cb157cf3aa51d28e441dbb2b671795f22140f8
[dev.regabi] cmd/compile: exporting, importing, and inlining functions with OCLOSURE

I have exporting, importing, and inlining of functions with closures
working in all cases (issue #28727). all.bash runs successfully without
errors.

Approach:
  - Write out the Func type, Dcls, ClosureVars, and Body when exporting
    an OCLOSURE.

  - When importing an OCLOSURE, read in the type, dcls, closure vars,
    and body, and then do roughly equivalent code to (*noder).funcLit

  - During inlining of a closure within inlined function, create new
    nodes for all params and local variables (including closure
    variables), so they can have a new Curfn and some other field
    values. Must substitute not only on the Nbody of the closure, but
    also the Type, Cvars, and Dcl fields.

Fixes #28727

Change-Id: I4da1e2567c3fa31a5121afbe82dc4e5ee32b3170
Reviewed-on: https://go-review.googlesource.com/c/go/+/283112
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
13 files changed:
src/cmd/compile/internal/escape/escape.go
src/cmd/compile/internal/inline/inl.go
src/cmd/compile/internal/ir/fmt.go
src/cmd/compile/internal/ir/node.go
src/cmd/compile/internal/noder/noder.go
src/cmd/compile/internal/typecheck/func.go
src/cmd/compile/internal/typecheck/iexport.go
src/cmd/compile/internal/typecheck/iimport.go
test/closure3.dir/main.go
test/closure5.dir/a.go [new file with mode: 0644]
test/closure5.dir/main.go [new file with mode: 0644]
test/closure5.go [new file with mode: 0644]
test/inline.go