]> Cypherpunks.ru repositories - gostls13.git/commit
all: remove PEM-encoded private keys from tests
authorRuss Cox <rsc@golang.org>
Tue, 21 May 2019 12:24:27 +0000 (08:24 -0400)
committerRuss Cox <rsc@golang.org>
Tue, 21 May 2019 20:03:55 +0000 (20:03 +0000)
commit02fe6ba95867b3858d62958ce487a47798bef1b5
treea1f2d191e301edfb88cc458bf1cd9127f5f956df
parent798e0b38ed8b23da010b1a8cd6c91f201248e40d
all: remove PEM-encoded private keys from tests

Gerrit is complaining about pushes that affect these files
and forcing people to use -o nokeycheck, which defeats
the point of the check. Hide the keys from this kind of scan
by marking them explicitly as testing keys.

This is a little annoying but better than training everyone
who ever edits one of these test files to reflexively override
the Gerrit check.

The only remaining keys explicitly marked as private instead
of testing are in examples, and there's not much to do
about those. Hopefully they are not edited as much.

Change-Id: I4431592b5266cb39fe6a80b40e742d97da803a0b
Reviewed-on: https://go-review.googlesource.com/c/go/+/178178
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/crypto/rsa/pkcs1v15_test.go
src/crypto/tls/handshake_server_test.go
src/crypto/tls/tls_test.go
src/crypto/x509/pem_decrypt_test.go
src/crypto/x509/x509_test.go
src/crypto/x509/x509_test_import.go
src/encoding/pem/pem_test.go
src/net/http/internal/testcert.go
src/net/smtp/smtp_test.go