]> Cypherpunks.ru repositories - nncp.git/blobdiff - src/tx.go
nncp-exec -nocompress/-use-tmp options
[nncp.git] / src / tx.go
index 67bb659a672426895919fcd5961633c75d455df9..3352f861a8465d63e95cfdacdce8a724fb203db5 100644 (file)
--- a/src/tx.go
+++ b/src/tx.go
@@ -1,6 +1,6 @@
 /*
 NNCP -- Node to Node copy, utilities for store-and-forward data exchange
-Copyright (C) 2016-2019 Sergey Matveev <stargrave@stargrave.org>
+Copyright (C) 2016-2021 Sergey Matveev <stargrave@stargrave.org>
 
 This program is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
@@ -86,7 +86,7 @@ func (ctx *Ctx) Tx(
                        "size": size,
                }, "wrote")
                errs <- PktEncWrite(ctx.Self, hops[0], pkt, nice, size, padSize, src, dst)
-               dst.Close()
+               dst.Close() // #nosec G104
        }(curSize, src, pipeW)
        curSize = PktEncOverhead + PktSizeOverhead + sizeWithTags(PktOverhead+curSize) + padSize
 
@@ -102,14 +102,14 @@ func (ctx *Ctx) Tx(
                                "size": size,
                        }, "trns wrote")
                        errs <- PktEncWrite(ctx.Self, node, pkt, nice, size, 0, src, dst)
-                       dst.Close()
+                       dst.Close() // #nosec G104
                }(hops[i], pktTrns, curSize, pipeRPrev, pipeW)
                curSize = PktEncOverhead + PktSizeOverhead + sizeWithTags(PktOverhead+curSize)
        }
        go func() {
                _, err := CopyProgressed(
-                       tmp.W, pipeR,
-                       SDS{"xx": string(TTx), "pkt": pktName, "fullsize": curSize},
+                       tmp.W, pipeR, "Tx",
+                       SDS{"pkt": pktName, "fullsize": curSize},
                        ctx.ShowPrgrs,
                )
                errs <- err
@@ -117,13 +117,13 @@ func (ctx *Ctx) Tx(
        for i := 0; i <= len(hops); i++ {
                err = <-errs
                if err != nil {
-                       tmp.Fd.Close()
+                       tmp.Fd.Close() // #nosec G104
                        return nil, err
                }
        }
        nodePath := filepath.Join(ctx.Spool, lastNode.Id.String())
        err = tmp.Commit(filepath.Join(nodePath, string(TTx)))
-       os.Symlink(nodePath, filepath.Join(ctx.Spool, lastNode.Name))
+       os.Symlink(nodePath, filepath.Join(ctx.Spool, lastNode.Name)) // #nosec G104
        return lastNode, err
 }
 
@@ -131,45 +131,63 @@ type DummyCloser struct{}
 
 func (dc DummyCloser) Close() error { return nil }
 
-func prepareTxFile(srcPath string) (reader io.Reader, closer io.Closer, fileSize int64, archived bool, rerr error) {
-       if srcPath == "-" {
-               // Read content from stdin, saving to temporary file, encrypting
-               // on the fly
-               src, err := ioutil.TempFile("", "nncp-file")
-               if err != nil {
-                       rerr = err
-                       return
-               }
-               os.Remove(src.Name())
-               tmpW := bufio.NewWriter(src)
-               tmpKey := make([]byte, chacha20poly1305.KeySize)
-               if _, rerr = rand.Read(tmpKey[:]); rerr != nil {
-                       return
-               }
-               aead, err := chacha20poly1305.New(tmpKey)
-               if err != nil {
-                       rerr = err
-                       return
-               }
-               nonce := make([]byte, aead.NonceSize())
-               written, err := aeadProcess(aead, nonce, true, bufio.NewReader(os.Stdin), tmpW)
-               if err != nil {
-                       rerr = err
-                       return
-               }
-               fileSize = int64(written)
-               if err = tmpW.Flush(); err != nil {
-                       return
+func throughTmpFile(r io.Reader) (
+       reader io.Reader,
+       closer io.Closer,
+       fileSize int64,
+       rerr error,
+) {
+       src, err := ioutil.TempFile("", "nncp-file")
+       if err != nil {
+               rerr = err
+               return
+       }
+       os.Remove(src.Name()) // #nosec G104
+       tmpW := bufio.NewWriter(src)
+       tmpKey := make([]byte, chacha20poly1305.KeySize)
+       if _, rerr = rand.Read(tmpKey[:]); rerr != nil {
+               return
+       }
+       aead, err := chacha20poly1305.New(tmpKey)
+       if err != nil {
+               rerr = err
+               return
+       }
+       nonce := make([]byte, aead.NonceSize())
+       written, err := aeadProcess(aead, nonce, true, r, tmpW)
+       if err != nil {
+               rerr = err
+               return
+       }
+       fileSize = int64(written)
+       if err = tmpW.Flush(); err != nil {
+               rerr = err
+               return
+       }
+       if _, err = src.Seek(0, io.SeekStart); err != nil {
+               rerr = err
+               return
+       }
+       r, w := io.Pipe()
+       go func() {
+               if _, err := aeadProcess(aead, nonce, false, bufio.NewReader(src), w); err != nil {
+                       w.CloseWithError(err) // #nosec G104
                }
-               src.Seek(0, io.SeekStart)
-               r, w := io.Pipe()
-               go func() {
-                       if _, err := aeadProcess(aead, nonce, false, bufio.NewReader(src), w); err != nil {
-                               w.CloseWithError(err)
-                       }
-               }()
-               reader = r
-               closer = src
+       }()
+       reader = r
+       closer = src
+       return
+}
+
+func prepareTxFile(srcPath string) (
+       reader io.Reader,
+       closer io.Closer,
+       fileSize int64,
+       archived bool,
+       rerr error,
+) {
+       if srcPath == "-" {
+               reader, closer, fileSize, rerr = throughTmpFile(bufio.NewReader(os.Stdin))
                return
        }
 
@@ -244,7 +262,7 @@ func prepareTxFile(srcPath string) (reader io.Reader, closer io.Closer, fileSize
        closer = DummyCloser{}
        fileSize += 2 * TarBlockSize // termination block
 
-       go func() {
+       go func() error {
                tarWr := tar.NewWriter(w)
                hdr := tar.Header{
                        Typeflag: tar.TypeDir,
@@ -258,7 +276,7 @@ func prepareTxFile(srcPath string) (reader io.Reader, closer io.Closer, fileSize
                        hdr.Name = basePath + e.path[len(rootPath):]
                        hdr.ModTime = e.modTime
                        if err = tarWr.WriteHeader(&hdr); err != nil {
-                               w.CloseWithError(err)
+                               return w.CloseWithError(err)
                        }
                }
                hdr.Typeflag = tar.TypeReg
@@ -268,20 +286,23 @@ func prepareTxFile(srcPath string) (reader io.Reader, closer io.Closer, fileSize
                        hdr.ModTime = e.modTime
                        hdr.Size = e.size
                        if err = tarWr.WriteHeader(&hdr); err != nil {
-                               w.CloseWithError(err)
+                               return w.CloseWithError(err)
                        }
                        fd, err := os.Open(e.path)
                        if err != nil {
-                               w.CloseWithError(err)
+                               fd.Close() // #nosec G104
+                               return w.CloseWithError(err)
                        }
-                       _, err = io.Copy(tarWr, bufio.NewReader(fd))
-                       if err != nil {
-                               w.CloseWithError(err)
+                       if _, err = io.Copy(tarWr, bufio.NewReader(fd)); err != nil {
+                               fd.Close() // #nosec G104
+                               return w.CloseWithError(err)
                        }
-                       fd.Close()
+                       fd.Close() // #nosec G104
                }
-               tarWr.Close()
-               w.Close()
+               if err = tarWr.Close(); err != nil {
+                       return w.CloseWithError(err)
+               }
+               return w.Close()
        }()
        return
 }
@@ -474,31 +495,94 @@ func (ctx *Ctx) TxExec(
        args []string,
        in io.Reader,
        minSize int64,
+       useTmp bool,
+       noCompress bool,
 ) error {
        path := make([][]byte, 0, 1+len(args))
        path = append(path, []byte(handle))
        for _, arg := range args {
                path = append(path, []byte(arg))
        }
-       pkt, err := NewPkt(PktTypeExec, replyNice, bytes.Join(path, []byte{0}))
-       if err != nil {
-               return err
+       pktType := PktTypeExec
+       if noCompress {
+               pktType = PktTypeExecFat
        }
-       var compressed bytes.Buffer
-       compressor, err := zstd.NewWriter(
-               &compressed,
-               zstd.WithEncoderLevel(zstd.SpeedDefault),
-       )
+       pkt, err := NewPkt(pktType, replyNice, bytes.Join(path, []byte{0}))
        if err != nil {
                return err
        }
-       _, err = io.Copy(compressor, in)
-       compressor.Close()
-       if err != nil {
-               return err
+       var size int64
+
+       if !noCompress && !useTmp {
+               var compressed bytes.Buffer
+               compressor, err := zstd.NewWriter(
+                       &compressed,
+                       zstd.WithEncoderLevel(zstd.SpeedDefault),
+               )
+               if err != nil {
+                       return err
+               }
+               if _, err = io.Copy(compressor, in); err != nil {
+                       compressor.Close() // #nosec G104
+                       return err
+               }
+               if err = compressor.Close(); err != nil {
+                       return err
+               }
+               size = int64(compressed.Len())
+               _, err = ctx.Tx(node, pkt, nice, size, minSize, &compressed, handle)
+       }
+       if noCompress && !useTmp {
+               var data bytes.Buffer
+               if _, err = io.Copy(&data, in); err != nil {
+                       return err
+               }
+               size = int64(data.Len())
+               _, err = ctx.Tx(node, pkt, nice, size, minSize, &data, handle)
        }
-       size := int64(compressed.Len())
-       _, err = ctx.Tx(node, pkt, nice, size, minSize, &compressed, handle)
+       if !noCompress && useTmp {
+               r, w := io.Pipe()
+               compressor, err := zstd.NewWriter(w, zstd.WithEncoderLevel(zstd.SpeedDefault))
+               if err != nil {
+                       return err
+               }
+               copyErr := make(chan error)
+               go func() {
+                       _, err := io.Copy(compressor, in)
+                       if err != nil {
+                               compressor.Close() // #nosec G104
+                               copyErr <- err
+                       }
+                       err = compressor.Close()
+                       w.Close()
+                       copyErr <- err
+               }()
+               tmpReader, closer, fileSize, err := throughTmpFile(r)
+               if closer != nil {
+                       defer closer.Close()
+               }
+               if err != nil {
+                       return err
+               }
+               err = <-copyErr
+               if err != nil {
+                       return err
+               }
+               size = fileSize
+               _, err = ctx.Tx(node, pkt, nice, size, minSize, tmpReader, handle)
+       }
+       if noCompress && useTmp {
+               tmpReader, closer, fileSize, err := throughTmpFile(in)
+               if closer != nil {
+                       defer closer.Close()
+               }
+               if err != nil {
+                       return err
+               }
+               size = fileSize
+               _, err = ctx.Tx(node, pkt, nice, size, minSize, tmpReader, handle)
+       }
+
        sds := SDS{
                "type":      "exec",
                "node":      node.Id,
@@ -532,11 +616,11 @@ func (ctx *Ctx) TxTrns(node *Node, nice uint8, size int64, src io.Reader) error
        if err != nil {
                return err
        }
-       if _, err = CopyProgressed(tmp.W, src, SDS{
-               "xx":       string(TTx),
-               "pkt":      node.Id.String(),
-               "fullsize": size,
-       }, ctx.ShowPrgrs); err != nil {
+       if _, err = CopyProgressed(
+               tmp.W, src, "Tx trns",
+               SDS{"pkt": node.Id.String(), "fullsize": size},
+               ctx.ShowPrgrs,
+       ); err != nil {
                return err
        }
        nodePath := filepath.Join(ctx.Spool, node.Id.String())
@@ -546,6 +630,6 @@ func (ctx *Ctx) TxTrns(node *Node, nice uint8, size int64, src io.Reader) error
        } else {
                ctx.LogI("tx", SdsAdd(sds, SDS{"err": err}), "sent")
        }
-       os.Symlink(nodePath, filepath.Join(ctx.Spool, node.Name))
+       os.Symlink(nodePath, filepath.Join(ctx.Spool, node.Name)) // #nosec G104
        return err
 }