]> Cypherpunks.ru repositories - nncp.git/blobdiff - src/cmd/nncp-bundle/main.go
Ignore many errors
[nncp.git] / src / cmd / nncp-bundle / main.go
index 60bb1130c83d09559084b633d7f5c3f9cea1c5d7..1cfdd45088ff9df995b653119030c764429eac8b 100644 (file)
@@ -1,6 +1,6 @@
 /*
 NNCP -- Node to Node copy, utilities for store-and-forward data exchange
-Copyright (C) 2016-2019 Sergey Matveev <stargrave@stargrave.org>
+Copyright (C) 2016-2020 Sergey Matveev <stargrave@stargrave.org>
 
 This program is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
@@ -22,6 +22,7 @@ import (
        "archive/tar"
        "bufio"
        "bytes"
+       "errors"
        "flag"
        "fmt"
        "io"
@@ -29,7 +30,6 @@ import (
        "log"
        "os"
        "path/filepath"
-       "strconv"
        "strings"
 
        xdr "github.com/davecgh/go-xdr/xdr2"
@@ -63,6 +63,8 @@ func main() {
                spoolPath = flag.String("spool", "", "Override path to spool")
                logPath   = flag.String("log", "", "Override path to logfile")
                quiet     = flag.Bool("quiet", false, "Print only errors")
+               showPrgrs = flag.Bool("progress", false, "Force progress showing")
+               omitPrgrs = flag.Bool("noprogress", false, "Omit progress showing")
                debug     = flag.Bool("debug", false, "Print debug messages")
                version   = flag.Bool("version", false, "Print version information")
                warranty  = flag.Bool("warranty", false, "Print warranty information")
@@ -88,7 +90,15 @@ func main() {
                log.Fatalln("At least one of -rx and -tx must be specified")
        }
 
-       ctx, err := nncp.CtxFromCmdline(*cfgPath, *spoolPath, *logPath, *quiet, *debug)
+       ctx, err := nncp.CtxFromCmdline(
+               *cfgPath,
+               *spoolPath,
+               *logPath,
+               *quiet,
+               *showPrgrs,
+               *omitPrgrs,
+               *debug,
+       )
        if err != nil {
                log.Fatalln("Error during initialization:", err)
        }
@@ -117,7 +127,7 @@ func main() {
                                sds["pkt"] = pktName
                                if job.PktEnc.Nice > nice {
                                        ctx.LogD("nncp-bundle", sds, "too nice")
-                                       job.Fd.Close()
+                                       job.Fd.Close() // #nosec G104
                                        continue
                                }
                                if err = tarWr.WriteHeader(&tar.Header{
@@ -142,10 +152,17 @@ func main() {
                                }); err != nil {
                                        log.Fatalln("Error writing tar header:", err)
                                }
-                               if _, err = io.Copy(tarWr, job.Fd); err != nil {
+                               if _, err = nncp.CopyProgressed(
+                                       tarWr, job.Fd, "Tx",
+                                       nncp.SdsAdd(sds, nncp.SDS{
+                                               "pkt":      nncp.Base32Codec.EncodeToString(job.HshValue[:]),
+                                               "fullsize": job.Size,
+                                       }),
+                                       ctx.ShowPrgrs,
+                               ); err != nil {
                                        log.Fatalln("Error during copying to tar:", err)
                                }
-                               job.Fd.Close()
+                               job.Fd.Close() // #nosec G104
                                if err = tarWr.Flush(); err != nil {
                                        log.Fatalln("Error during tar flushing:", err)
                                }
@@ -157,9 +174,7 @@ func main() {
                                                log.Fatalln("Error during deletion:", err)
                                        }
                                }
-                               ctx.LogI("nncp-bundle", nncp.SdsAdd(sds, nncp.SDS{
-                                       "size": strconv.FormatInt(job.Size, 10),
-                               }), "")
+                               ctx.LogI("nncp-bundle", nncp.SdsAdd(sds, nncp.SDS{"size": job.Size}), "")
                        }
                }
                if err = tarWr.Close(); err != nil {
@@ -167,33 +182,27 @@ func main() {
                }
        } else {
                bufStdin := bufio.NewReaderSize(os.Stdin, CopyBufSize*2)
-               var peeked []byte
-               var prefixIdx int
-               var tarR *tar.Reader
-               var entry *tar.Header
-               var exists bool
                pktEncBuf := make([]byte, nncp.PktEncOverhead)
                var pktEnc *nncp.PktEnc
-               var pktName string
-               var selfPath string
-               var dstPath string
                for {
-                       peeked, err = bufStdin.Peek(CopyBufSize)
+                       peeked, err := bufStdin.Peek(CopyBufSize)
                        if err != nil && err != io.EOF {
                                log.Fatalln("Error during reading:", err)
                        }
-                       prefixIdx = bytes.Index(peeked, []byte(nncp.NNCPBundlePrefix))
+                       prefixIdx := bytes.Index(peeked, []byte(nncp.NNCPBundlePrefix))
                        if prefixIdx == -1 {
                                if err == io.EOF {
                                        break
                                }
-                               bufStdin.Discard(bufStdin.Buffered() - (len(nncp.NNCPBundlePrefix) - 1))
+                               bufStdin.Discard(bufStdin.Buffered() - (len(nncp.NNCPBundlePrefix) - 1)) // #nosec G104
                                continue
                        }
-                       bufStdin.Discard(prefixIdx)
-                       tarR = tar.NewReader(bufStdin)
+                       if _, err = bufStdin.Discard(prefixIdx); err != nil {
+                               panic(err)
+                       }
+                       tarR := tar.NewReader(bufStdin)
                        sds["xx"] = string(nncp.TRx)
-                       entry, err = tarR.Next()
+                       entry, err := tarR.Next()
                        if err != nil {
                                if err != io.EOF {
                                        ctx.LogD(
@@ -224,9 +233,13 @@ func main() {
                                ctx.LogD("nncp-bundle", sds, "Too small packet")
                                continue
                        }
-                       pktName = filepath.Base(entry.Name)
-                       if _, err = nncp.FromBase32(pktName); err != nil {
-                               ctx.LogD("nncp-bundle", sds, "Bad packet name")
+                       if !ctx.IsEnoughSpace(entry.Size) {
+                               ctx.LogE("nncp-bundle", sds, errors.New("not enough spool space"), "")
+                               continue
+                       }
+                       pktName := filepath.Base(entry.Name)
+                       if _, err = nncp.Base32Codec.DecodeString(pktName); err != nil {
+                               ctx.LogD("nncp-bundle", nncp.SdsAdd(sds, nncp.SDS{"err": "bad packet name"}), "")
                                continue
                        }
                        if _, err = io.ReadFull(tarR, pktEncBuf); err != nil {
@@ -247,16 +260,16 @@ func main() {
                        }
                        if *pktEnc.Sender == *ctx.SelfId && *doDelete {
                                if len(nodeIds) > 0 {
-                                       if _, exists = nodeIds[*pktEnc.Recipient]; !exists {
+                                       if _, exists := nodeIds[*pktEnc.Recipient]; !exists {
                                                ctx.LogD("nncp-bundle", sds, "Recipient is not requested")
                                                continue
                                        }
                                }
-                               nodeId32 := nncp.ToBase32(pktEnc.Recipient[:])
+                               nodeId32 := nncp.Base32Codec.EncodeToString(pktEnc.Recipient[:])
                                sds["xx"] = string(nncp.TTx)
                                sds["node"] = nodeId32
                                sds["pkt"] = pktName
-                               dstPath = filepath.Join(
+                               dstPath := filepath.Join(
                                        ctx.Spool,
                                        nodeId32,
                                        string(nncp.TTx),
@@ -273,16 +286,20 @@ func main() {
                                if _, err = hsh.Write(pktEncBuf); err != nil {
                                        log.Fatalln("Error during writing:", err)
                                }
-                               if _, err = io.Copy(hsh, tarR); err != nil {
+                               if _, err = nncp.CopyProgressed(
+                                       hsh, tarR, "Rx",
+                                       nncp.SdsAdd(sds, nncp.SDS{"fullsize": entry.Size}),
+                                       ctx.ShowPrgrs,
+                               ); err != nil {
                                        log.Fatalln("Error during copying:", err)
                                }
-                               if nncp.ToBase32(hsh.Sum(nil)) == pktName {
+                               if nncp.Base32Codec.EncodeToString(hsh.Sum(nil)) == pktName {
                                        ctx.LogI("nncp-bundle", sds, "removed")
                                        if !*dryRun {
-                                               os.Remove(dstPath)
+                                               os.Remove(dstPath) // #nosec G104
                                        }
                                } else {
-                                       ctx.LogE("nncp-bundle", sds, "bad checksum")
+                                       ctx.LogE("nncp-bundle", sds, errors.New("bad checksum"), "")
                                }
                                continue
                        }
@@ -291,15 +308,16 @@ func main() {
                                continue
                        }
                        if len(nodeIds) > 0 {
-                               if _, exists = nodeIds[*pktEnc.Sender]; !exists {
+                               if _, exists := nodeIds[*pktEnc.Sender]; !exists {
                                        ctx.LogD("nncp-bundle", sds, "Sender is not requested")
                                        continue
                                }
                        }
-                       sds["node"] = nncp.ToBase32(pktEnc.Recipient[:])
+                       sds["node"] = nncp.Base32Codec.EncodeToString(pktEnc.Recipient[:])
                        sds["pkt"] = pktName
-                       selfPath = filepath.Join(ctx.Spool, ctx.SelfId.String(), string(nncp.TRx))
-                       dstPath = filepath.Join(selfPath, pktName)
+                       sds["fullsize"] = entry.Size
+                       selfPath := filepath.Join(ctx.Spool, ctx.SelfId.String(), string(nncp.TRx))
+                       dstPath := filepath.Join(selfPath, pktName)
                        if _, err = os.Stat(dstPath); err == nil || !os.IsNotExist(err) {
                                ctx.LogD("nncp-bundle", sds, "Packet already exists")
                                continue
@@ -317,11 +335,11 @@ func main() {
                                        if _, err = hsh.Write(pktEncBuf); err != nil {
                                                log.Fatalln("Error during writing:", err)
                                        }
-                                       if _, err = io.Copy(hsh, tarR); err != nil {
+                                       if _, err = nncp.CopyProgressed(hsh, tarR, "check", sds, ctx.ShowPrgrs); err != nil {
                                                log.Fatalln("Error during copying:", err)
                                        }
-                                       if nncp.ToBase32(hsh.Sum(nil)) != pktName {
-                                               ctx.LogE("nncp-bundle", sds, "bad checksum")
+                                       if nncp.Base32Codec.EncodeToString(hsh.Sum(nil)) != pktName {
+                                               ctx.LogE("nncp-bundle", sds, errors.New("bad checksum"), "")
                                                continue
                                        }
                                } else {
@@ -332,25 +350,25 @@ func main() {
                                        if _, err = tmp.W.Write(pktEncBuf); err != nil {
                                                log.Fatalln("Error during writing:", err)
                                        }
-                                       if _, err = io.Copy(tmp.W, tarR); err != nil {
+                                       if _, err = nncp.CopyProgressed(tmp.W, tarR, "check", sds, ctx.ShowPrgrs); err != nil {
                                                log.Fatalln("Error during copying:", err)
                                        }
                                        if err = tmp.W.Flush(); err != nil {
                                                log.Fatalln("Error during flusing:", err)
                                        }
-                                       if nncp.ToBase32(tmp.Hsh.Sum(nil)) == pktName {
+                                       if nncp.Base32Codec.EncodeToString(tmp.Hsh.Sum(nil)) == pktName {
                                                if err = tmp.Commit(selfPath); err != nil {
                                                        log.Fatalln("Error during commiting:", err)
                                                }
                                        } else {
-                                               ctx.LogE("nncp-bundle", sds, "bad checksum")
+                                               ctx.LogE("nncp-bundle", sds, errors.New("bad checksum"), "")
                                                tmp.Cancel()
                                                continue
                                        }
                                }
                        } else {
                                if *dryRun {
-                                       if _, err = io.Copy(ioutil.Discard, tarR); err != nil {
+                                       if _, err = nncp.CopyProgressed(ioutil.Discard, tarR, "Rx", sds, ctx.ShowPrgrs); err != nil {
                                                log.Fatalln("Error during copying:", err)
                                        }
                                } else {
@@ -362,7 +380,7 @@ func main() {
                                        if _, err = bufTmp.Write(pktEncBuf); err != nil {
                                                log.Fatalln("Error during writing:", err)
                                        }
-                                       if _, err = io.Copy(bufTmp, tarR); err != nil {
+                                       if _, err = nncp.CopyProgressed(bufTmp, tarR, "Rx", sds, ctx.ShowPrgrs); err != nil {
                                                log.Fatalln("Error during copying:", err)
                                        }
                                        if err = bufTmp.Flush(); err != nil {
@@ -371,7 +389,9 @@ func main() {
                                        if err = tmp.Sync(); err != nil {
                                                log.Fatalln("Error during syncing:", err)
                                        }
-                                       tmp.Close()
+                                       if err = tmp.Close(); err != nil {
+                                               log.Fatalln("Error during closing:", err)
+                                       }
                                        if err = os.MkdirAll(selfPath, os.FileMode(0777)); err != nil {
                                                log.Fatalln("Error during mkdir:", err)
                                        }
@@ -384,7 +404,7 @@ func main() {
                                }
                        }
                        ctx.LogI("nncp-bundle", nncp.SdsAdd(sds, nncp.SDS{
-                               "size": strconv.FormatInt(entry.Size, 10),
+                               "size": sds["fullsize"],
                        }), "")
                }
        }