1 // Copyright 2013 The Go Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style
3 // license that can be found in the LICENSE file.
5 // This file implements tests for various issues.
23 func mustParse(t *testing.T, src string) *ast.File {
24 f, err := parser.ParseFile(fset, "", src, 0)
30 func TestIssue5770(t *testing.T) {
31 f := mustParse(t, `package p; type S struct{T}`)
32 conf := Config{Importer: importer.Default()}
33 _, err := conf.Check(f.Name.Name, fset, []*ast.File{f}, nil) // do not crash
34 const want = "undefined: T"
35 if err == nil || !strings.Contains(err.Error(), want) {
36 t.Errorf("got: %v; want: %s", err, want)
40 func TestIssue5849(t *testing.T) {
48 _ = uint64(64 << s + s)
49 _ = (interface{})("foo")
50 _ = (interface{})(nil)
52 f := mustParse(t, src)
55 types := make(map[ast.Expr]TypeAndValue)
56 _, err := conf.Check(f.Name.Name, fset, []*ast.File{f}, &Info{Types: types})
61 for x, tv := range types {
63 switch x := x.(type) {
73 want = Typ[Uint] // because of "+ s", s is of type uint
79 want = Typ[UntypedNil]
82 if want != nil && !Identical(tv.Type, want) {
83 t.Errorf("got %s; want %s", tv.Type, want)
88 func TestIssue6413(t *testing.T) {
97 f := mustParse(t, src)
100 types := make(map[ast.Expr]TypeAndValue)
101 _, err := conf.Check(f.Name.Name, fset, []*ast.File{f}, &Info{Types: types})
108 for x, tv := range types {
109 if _, ok := x.(*ast.CallExpr); ok {
111 t.Errorf("%s: got %s; want %s", fset.Position(x.Pos()), tv.Type, want)
118 t.Errorf("got %d CallExprs; want 2", n)
122 func TestIssue7245(t *testing.T) {
125 func (T) m() (res bool) { return }
126 type T struct{} // receiver type after method declaration
128 f := mustParse(t, src)
131 defs := make(map[*ast.Ident]Object)
132 _, err := conf.Check(f.Name.Name, fset, []*ast.File{f}, &Info{Defs: defs})
137 m := f.Decls[0].(*ast.FuncDecl)
138 res1 := defs[m.Name].(*Func).Type().(*Signature).Results().At(0)
139 res2 := defs[m.Type.Results.List[0].Names[0]].(*Var)
142 t.Errorf("got %s (%p) != %s (%p)", res1, res2, res1, res2)
146 // This tests that uses of existing vars on the LHS of an assignment
147 // are Uses, not Defs; and also that the (illegal) use of a non-var on
148 // the LHS of an assignment is a Use nonetheless.
149 func TestIssue7827(t *testing.T) {
153 const w = 1 // defs w
154 x, y := 2, 3 // defs x, y
155 w, x, z := 4, 5, 6 // uses w, x, defs z; error: cannot assign to w
156 _, _, _ = x, y, z // uses x, y, z
159 f := mustParse(t, src)
161 const want = `L3 defs func p._()
162 L4 defs const w untyped int
166 L6 uses const w untyped int
172 // don't abort at the first error
173 conf := Config{Error: func(err error) { t.Log(err) }}
174 defs := make(map[*ast.Ident]Object)
175 uses := make(map[*ast.Ident]Object)
176 _, err := conf.Check(f.Name.Name, fset, []*ast.File{f}, &Info{Defs: defs, Uses: uses})
177 if s := fmt.Sprint(err); !strings.HasSuffix(s, "cannot assign to w") {
178 t.Errorf("Check: unexpected error: %s", s)
182 for id, obj := range defs {
184 fact := fmt.Sprintf("L%d defs %s", fset.Position(id.Pos()).Line, obj)
185 facts = append(facts, fact)
188 for id, obj := range uses {
189 fact := fmt.Sprintf("L%d uses %s", fset.Position(id.Pos()).Line, obj)
190 facts = append(facts, fact)
194 got := strings.Join(facts, "\n")
196 t.Errorf("Unexpected defs/uses\ngot:\n%s\nwant:\n%s", got, want)
200 // This tests that the package associated with the types.Object.Pkg method
201 // is the type's package independent of the order in which the imports are
202 // listed in the sources src1, src2 below.
203 // The actual issue is in go/internal/gcimporter which has a corresponding
204 // test; we leave this test here to verify correct behavior at the go/types
206 func TestIssue13898(t *testing.T) {
207 testenv.MustHaveGoBuild(t)
216 for _, obj := range info.Uses {
221 // like src0, but also imports go/importer
232 for _, obj := range info.Uses {
237 // like src1 but with different import order
238 // (used to fail with this issue)
249 for _, obj := range info.Uses {
254 f := func(test, src string) {
255 f := mustParse(t, src)
256 cfg := Config{Importer: importer.Default()}
257 info := Info{Uses: make(map[*ast.Ident]Object)}
258 _, err := cfg.Check("main", fset, []*ast.File{f}, &info)
265 for id, obj := range info.Uses {
266 if id.Name == "Pkg" {
272 t.Fatalf("%s: got %d entries named Pkg; want 1", test, count)
274 if pkg.Name() != "types" {
275 t.Fatalf("%s: got %v; want package types", test, pkg)
284 func TestIssue22525(t *testing.T) {
285 f := mustParse(t, `package p; func f() { var a, b, c, d, e int }`)
288 conf := Config{Error: func(err error) { got += err.Error() + "\n" }}
289 conf.Check(f.Name.Name, fset, []*ast.File{f}, nil) // do not crash
291 1:27: a declared and not used
292 1:30: b declared and not used
293 1:33: c declared and not used
294 1:36: d declared and not used
295 1:39: e declared and not used
298 t.Errorf("got: %swant: %s", got, want)
302 func TestIssue25627(t *testing.T) {
303 const prefix = `package p; import "unsafe"; type P *struct{}; type I interface{}; type T `
304 // The src strings (without prefix) are constructed such that the number of semicolons
305 // plus one corresponds to the number of fields expected in the respective struct.
306 for _, src := range []string{
307 `struct { x Missing }`,
308 `struct { Missing }`,
309 `struct { *Missing }`,
310 `struct { unsafe.Pointer }`,
313 `struct { a int; b Missing; *Missing }`,
315 f := mustParse(t, prefix+src)
317 cfg := Config{Importer: importer.Default(), Error: func(err error) {}}
318 info := &Info{Types: make(map[ast.Expr]TypeAndValue)}
319 _, err := cfg.Check(f.Name.Name, fset, []*ast.File{f}, info)
321 if _, ok := err.(Error); !ok {
326 ast.Inspect(f, func(n ast.Node) bool {
327 if spec, _ := n.(*ast.TypeSpec); spec != nil {
328 if tv, ok := info.Types[spec.Type]; ok && spec.Name.Name == "T" {
329 want := strings.Count(src, ";") + 1
330 if got := tv.Type.(*Struct).NumFields(); got != want {
331 t.Errorf("%s: got %d fields; want %d", src, got, want)
340 func TestIssue28005(t *testing.T) {
341 // method names must match defining interface name for this test
342 // (see last comment in this function)
343 sources := [...]string{
344 "package p; type A interface{ A() }",
345 "package p; type B interface{ B() }",
346 "package p; type X interface{ A; B }",
349 // compute original file ASTs
350 var orig [len(sources)]*ast.File
351 for i, src := range sources {
352 orig[i] = mustParse(t, src)
355 // run the test for all order permutations of the incoming files
356 for _, perm := range [][len(sources)]int{
364 // create file order permutation
365 files := make([]*ast.File, len(sources))
366 for i := range perm {
367 files[i] = orig[perm[i]]
370 // type-check package with given file order permutation
372 info := &Info{Defs: make(map[*ast.Ident]Object)}
373 _, err := conf.Check("", fset, files, info)
378 // look for interface object X
380 for name, def := range info.Defs {
381 if name.Name == "X" {
387 t.Fatal("object X not found")
389 iface := obj.Type().Underlying().(*Interface) // object X must be an interface
391 // Each iface method m is embedded; and m's receiver base type name
392 // must match the method's name per the choice in the source file.
393 for i := 0; i < iface.NumMethods(); i++ {
395 recvName := m.Type().(*Signature).Recv().Type().(*Named).Obj().Name()
396 if recvName != m.Name() {
397 t.Errorf("perm %v: got recv %s; want %s", perm, recvName, m.Name())
403 func TestIssue28282(t *testing.T) {
404 // create type interface { error }
405 et := Universe.Lookup("error").Type()
406 it := NewInterfaceType(nil, []Type{et})
408 // verify that after completing the interface, the embedded method remains unchanged
409 want := et.Underlying().(*Interface).Method(0)
412 t.Fatalf("%s.Method(0): got %q (%p); want %q (%p)", it, got, got, want, want)
414 // verify that lookup finds the same method in both interfaces (redundant check)
415 obj, _, _ := LookupFieldOrMethod(et, false, nil, "Error")
417 t.Fatalf("%s.Lookup: got %q (%p); want %q (%p)", et, obj, obj, want, want)
419 obj, _, _ = LookupFieldOrMethod(it, false, nil, "Error")
421 t.Fatalf("%s.Lookup: got %q (%p); want %q (%p)", it, obj, obj, want, want)
425 func TestIssue29029(t *testing.T) {
426 f1 := mustParse(t, `package p; type A interface { M() }`)
427 f2 := mustParse(t, `package p; var B interface { A }`)
429 // printInfo prints the *Func definitions recorded in info, one *Func per line.
430 printInfo := func(info *Info) string {
431 var buf strings.Builder
432 for _, obj := range info.Defs {
433 if fn, ok := obj.(*Func); ok {
434 fmt.Fprintln(&buf, fn)
440 // The *Func (method) definitions for package p must be the same
441 // independent on whether f1 and f2 are type-checked together, or
444 // type-check together
446 info := &Info{Defs: make(map[*ast.Ident]Object)}
447 check := NewChecker(&conf, fset, NewPackage("", "p"), info)
448 if err := check.Files([]*ast.File{f1, f2}); err != nil {
451 want := printInfo(info)
453 // type-check incrementally
454 info = &Info{Defs: make(map[*ast.Ident]Object)}
455 check = NewChecker(&conf, fset, NewPackage("", "p"), info)
456 if err := check.Files([]*ast.File{f1}); err != nil {
459 if err := check.Files([]*ast.File{f2}); err != nil {
462 got := printInfo(info)
465 t.Errorf("\ngot : %swant: %s", got, want)
469 func TestIssue34151(t *testing.T) {
470 const asrc = `package a; type I interface{ M() }; type T struct { F interface { I } }`
471 const bsrc = `package b; import "a"; type T struct { F interface { a.I } }; var _ = a.T(T{})`
473 a, err := pkgFor("a", asrc, nil)
475 t.Fatalf("package %s failed to typecheck: %v", a.Name(), err)
478 bast := mustParse(t, bsrc)
479 conf := Config{Importer: importHelper{pkg: a}}
480 b, err := conf.Check(bast.Name.Name, fset, []*ast.File{bast}, nil)
482 t.Errorf("package %s failed to typecheck: %v", b.Name(), err)
486 type importHelper struct {
491 func (h importHelper) Import(path string) (*Package, error) {
492 if path == h.pkg.Path() {
495 if h.fallback == nil {
496 return nil, fmt.Errorf("got package path %q; want %q", path, h.pkg.Path())
498 return h.fallback.Import(path)
501 // TestIssue34921 verifies that we don't update an imported type's underlying
502 // type when resolving an underlying type. Specifically, when determining the
503 // underlying type of b.T (which is the underlying type of a.T, which is int)
504 // we must not set the underlying type of a.T again since that would lead to
505 // a race condition if package b is imported elsewhere, in a package that is
506 // concurrently type-checked.
507 func TestIssue34921(t *testing.T) {
509 if r := recover(); r != nil {
514 var sources = []string{
515 `package a; type T int`,
516 `package b; import "a"; type T a.T`,
520 for _, src := range sources {
521 f := mustParse(t, src)
522 conf := Config{Importer: importHelper{pkg: pkg}}
523 res, err := conf.Check(f.Name.Name, fset, []*ast.File{f}, nil)
525 t.Errorf("%q failed to typecheck: %v", src, err)
527 pkg = res // res is imported by the next package in this test
531 func TestIssue43088(t *testing.T) {
541 n1 := NewTypeName(token.NoPos, nil, "T1", nil)
542 T1 := NewNamed(n1, nil, nil)
543 n2 := NewTypeName(token.NoPos, nil, "T2", nil)
544 T2 := NewNamed(n2, nil, nil)
545 s1 := NewStruct([]*Var{NewField(token.NoPos, nil, "_", T2, false)}, nil)
547 s2 := NewStruct([]*Var{NewField(token.NoPos, nil, "_", T2, false)}, nil)
548 s3 := NewStruct([]*Var{NewField(token.NoPos, nil, "_", s2, false)}, nil)
551 // These calls must terminate (no endless recursion).
556 func TestIssue44515(t *testing.T) {
557 typ := Unsafe.Scope().Lookup("Pointer").Type()
559 got := TypeString(typ, nil)
560 want := "unsafe.Pointer"
562 t.Errorf("got %q; want %q", got, want)
565 qf := func(pkg *Package) string {
571 got = TypeString(typ, qf)
574 t.Errorf("got %q; want %q", got, want)
578 func TestIssue43124(t *testing.T) {
579 // TODO(rFindley) move this to testdata by enhancing support for importing.
581 // All involved packages have the same name (template). Error messages should
582 // disambiguate between text/template and html/template by printing the full
585 asrc = `package a; import "text/template"; func F(template.Template) {}; func G(int) {}`
595 // Packages should be fully qualified when there is ambiguity within the
596 // error string itself.
597 a.F(template /* ERROR cannot use.*html/template.* as .*text/template */ .Template{})
609 // Issue #46905: make sure template is not the first package qualified.
610 var _ fmt.Stringer = 1 // ERROR cannot use 1.*as fmt\.Stringer
612 // Packages should be fully qualified when there is ambiguity in reachable
613 // packages. In this case both a (and for that matter html/template) import
615 func _() { a.G(template /* ERROR cannot use .*html/template.*Template */ .Template{}) }
621 import "text/template"
625 // Verify that the current package name also causes disambiguation.
626 var _ T = template /* ERROR cannot use.*text/template.* as T value */.Template{}
630 a, err := pkgFor("a", asrc, nil)
632 t.Fatalf("package a failed to typecheck: %v", err)
634 imp := importHelper{pkg: a, fallback: importer.Default()}
636 testFiles(t, nil, []string{"b.go"}, [][]byte{[]byte(bsrc)}, false, imp)
637 testFiles(t, nil, []string{"c.go"}, [][]byte{[]byte(csrc)}, false, imp)
638 testFiles(t, nil, []string{"t.go"}, [][]byte{[]byte(tsrc)}, false, imp)
641 func TestIssue50646(t *testing.T) {
642 anyType := Universe.Lookup("any").Type()
643 comparableType := Universe.Lookup("comparable").Type()
645 if !Comparable(anyType) {
646 t.Errorf("any is not a comparable type")
648 if !Comparable(comparableType) {
649 t.Errorf("comparable is not a comparable type")
652 if Implements(anyType, comparableType.Underlying().(*Interface)) {
653 t.Errorf("any implements comparable")
655 if !Implements(comparableType, anyType.(*Interface)) {
656 t.Errorf("comparable does not implement any")
659 if AssignableTo(anyType, comparableType) {
660 t.Errorf("any assignable to comparable")
662 if !AssignableTo(comparableType, anyType) {
663 t.Errorf("comparable not assignable to any")
667 func TestIssue55030(t *testing.T) {
668 // makeSig makes the signature func(typ...)
669 makeSig := func(typ Type) {
670 par := NewVar(token.NoPos, nil, "", typ)
671 params := NewTuple(par)
672 NewSignatureType(nil, nil, nil, params, nil, true)
675 // makeSig must not panic for the following (example) types:
677 makeSig(NewSlice(Typ[Int]))
682 // P where P's core type is string
684 P := NewTypeName(token.NoPos, nil, "P", nil) // [P string]
685 makeSig(NewTypeParam(P, NewInterfaceType(nil, []Type{Typ[String]})))
688 // P where P's core type is an (unnamed) slice
690 P := NewTypeName(token.NoPos, nil, "P", nil) // [P []int]
691 makeSig(NewTypeParam(P, NewInterfaceType(nil, []Type{NewSlice(Typ[Int])})))
694 // P where P's core type is bytestring (i.e., string or []byte)
696 t1 := NewTerm(true, Typ[String]) // ~string
697 t2 := NewTerm(false, NewSlice(Typ[Byte])) // []byte
698 u := NewUnion([]*Term{t1, t2}) // ~string | []byte
699 P := NewTypeName(token.NoPos, nil, "P", nil) // [P ~string | []byte]
700 makeSig(NewTypeParam(P, NewInterfaceType(nil, []Type{u})))