From 57d488e9db5cddb4b2ae986838ce93fad0948eb4 Mon Sep 17 00:00:00 2001 From: Sergey Matveev Date: Mon, 17 Feb 2020 16:52:12 +0300 Subject: [PATCH] Simplify code with _values_for_encoding override --- pyderasn.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/pyderasn.py b/pyderasn.py index aa9f60c..8208efe 100755 --- a/pyderasn.py +++ b/pyderasn.py @@ -6367,17 +6367,16 @@ class Set(Sequence): tag_default = tag_encode(form=TagFormConstructed, num=17) asn1_type_name = "SET" - def _encode(self): - v = b"".join(value.encode() for value in sorted( - self._values_for_encoding(), + def _values_for_encoding(self): + return sorted( + super(Set, self)._values_for_encoding(), key=attrgetter("tag_order"), - )) - return b"".join((self.tag, len_encode(len(v)), v)) + ) def _encode_cer(self, writer): write_full(writer, self.tag + LENINDEF) for v in sorted( - self._values_for_encoding(), + super(Set, self)._values_for_encoding(), key=attrgetter("tag_order_cer"), ): v.encode_cer(writer) -- 2.44.0