From dd726a39166775b4d60f921f032b1b898e7d7001 Mon Sep 17 00:00:00 2001 From: Sergey Matveev Date: Sun, 1 Aug 2021 19:25:27 +0300 Subject: [PATCH] Fix lack of success messages printing --- doc/news.texi | 8 ++++++++ ifchange.go | 6 +++--- usage.go | 2 +- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/doc/news.texi b/doc/news.texi index a07870b..b00f197 100644 --- a/doc/news.texi +++ b/doc/news.texi @@ -1,6 +1,14 @@ @node News @unnumbered News +@anchor{Release 1_12_0} +@section Release 1.12.0 +@itemize +@item + Fix possible lack of success finish message printing if any of + targets fail. +@end itemize + @anchor{Release 1_11_0} @section Release 1.11.0 @itemize diff --git a/ifchange.go b/ifchange.go index 3a0ebf3..128d1af 100644 --- a/ifchange.go +++ b/ifchange.go @@ -116,7 +116,7 @@ func buildDependants(tgts []string) map[string]struct{} { } ok := true for i := 0; i < len(seen); i++ { - ok = ok && isOkRun(<-errs) + ok = isOkRun(<-errs) && ok } Jobs.Wait() close(errs) @@ -163,7 +163,7 @@ RebuildDeps: jobs++ } for i := 0; i < jobs; i++ { - ok = ok && isOkRun(<-errs) + ok = isOkRun(<-errs) && ok } if !ok { trace(CDebug, "dependants failed, skipping them") @@ -217,7 +217,7 @@ func ifchange(tgts []string, forced, traced bool) (bool, error) { } ok := true for ; jobs > 0; jobs-- { - ok = ok && isOkRun(<-errs) + ok = isOkRun(<-errs) && ok } return ok, nil } diff --git a/usage.go b/usage.go index 944658b..38ebb38 100644 --- a/usage.go +++ b/usage.go @@ -24,7 +24,7 @@ import ( ) const ( - Version = "1.11.0" + Version = "1.12.0" Warranty = `Copyright (C) 2020-2021 Sergey Matveev This program is free software: you can redistribute it and/or modify -- 2.44.0