From: Sergey Matveev <stargrave@stargrave.org>
Date: Wed, 15 Sep 2021 20:14:45 +0000 (+0300)
Subject: mktemp is unnecessary
X-Git-Tag: v1.14.0~1
X-Git-Url: http://www.git.cypherpunks.ru/?p=goredo.git;a=commitdiff_plain;h=045968a5a144dda187459380ddea4aa366382fde

mktemp is unnecessary

Because "prove" already creates temporary directory it works within.
---

diff --git a/t/goredo-deps-after-cd.t b/t/goredo-deps-after-cd.t
index a4014a1..bd25ae4 100755
--- a/t/goredo-deps-after-cd.t
+++ b/t/goredo-deps-after-cd.t
@@ -4,10 +4,6 @@ testname=`basename "$0"`
 test_description="Check that dependencies have correct relative path after cd"
 . $SHARNESS_TEST_SRCDIR/sharness.sh
 
-tmp=`mktemp -d`
-trap "rm -fr $tmp" HUP PIPE INT QUIT TERM EXIT
-
-cd $tmp
 mkdir -p bin src
 cat > bin/default.do <<EOF
 cd ../src
diff --git a/t/goredo-deps.t b/t/goredo-deps.t
index 5ab869c..9624059 100755
--- a/t/goredo-deps.t
+++ b/t/goredo-deps.t
@@ -4,10 +4,6 @@ testname=`basename "$0"`
 test_description="Check that the following use-case won't rebuild everytime and has correct dependencies"
 . $SHARNESS_TEST_SRCDIR/sharness.sh
 
-tmp=`mktemp -d`
-trap "rm -fr $tmp" HUP PIPE INT QUIT TERM EXIT
-
-cd $tmp
 mkdir -p sub
 cat > default.html.do <<EOF
 redo-ifchange \$2.pre
diff --git a/t/goredo-empty-dep.t b/t/goredo-empty-dep.t
index 1b4a6d2..ee942fc 100755
--- a/t/goredo-empty-dep.t
+++ b/t/goredo-empty-dep.t
@@ -4,10 +4,6 @@ testname=`basename "$0"`
 test_description="Check that empty target is a dependency and always OOD"
 . $SHARNESS_TEST_SRCDIR/sharness.sh
 
-tmp=`mktemp -d`
-trap "rm -fr $tmp" HUP PIPE INT QUIT TERM EXIT
-cd $tmp
-
 echo > foo.do
 cat > bar.do <<EOF
 redo-ifchange foo
diff --git a/t/goredo-failed-build.t b/t/goredo-failed-build.t
index 0643101..b5fb53c 100755
--- a/t/goredo-failed-build.t
+++ b/t/goredo-failed-build.t
@@ -4,10 +4,6 @@ testname=`basename "$0"`
 test_description="Check that failed build is still OOD target"
 . $SHARNESS_TEST_SRCDIR/sharness.sh
 
-tmp=`mktemp -d`
-trap "rm -fr $tmp" HUP PIPE INT QUIT TERM EXIT
-cd $tmp
-
 echo exit 1 > bar.do
 echo redo-ifchange bar > foo.do
 export REDO_NO_PROGRESS=1