From: Sergey Matveev <stargrave@stargrave.org>
Date: Thu, 23 Mar 2023 10:20:47 +0000 (+0300)
Subject: Too early defer
X-Git-Tag: v3.7.1~2
X-Git-Url: http://www.git.cypherpunks.ru/?p=gocheese.git;a=commitdiff_plain;h=0f9a4972ff6b08ea3af9bfd17417df688de4e2bd

Too early defer
---

diff --git a/upload.go b/upload.go
index b36a575..3765c56 100644
--- a/upload.go
+++ b/upload.go
@@ -108,12 +108,12 @@ func serveUpload(w http.ResponseWriter, r *http.Request) {
 			return
 		}
 		src, err := file.Open()
-		defer src.Close()
 		if err != nil {
 			log.Println("error", r.RemoteAddr, filename, err)
 			http.Error(w, err.Error(), http.StatusInternalServerError)
 			return
 		}
+		defer src.Close()
 		dst, err := TempFile(dirPath)
 		if err != nil {
 			log.Println("error", r.RemoteAddr, filename, err)