From: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Date: Sat, 7 Oct 2023 15:54:50 +0000 (+0700)
Subject: cmd/compile: fix ICE with parenthesized builtin calls
X-Git-Tag: go1.22rc1~658
X-Git-Url: http://www.git.cypherpunks.ru/?a=commitdiff_plain;h=2744155d369ca838be57d1eba90c3c6bfc4a3b30;p=gostls13.git

cmd/compile: fix ICE with parenthesized builtin calls

CL 419456 starts using lookupObj to find types2.Object associated with
builtin functions. However, the new code does not un-parenthesized the
callee expression, causing an ICE because of nil obj returned.

Un-parenthesizing the callee expression fixes the problem.

Fixes #63436

Change-Id: Iebb4fbc08575e7d0b1dbd026c98e8f949ca16460
Reviewed-on: https://go-review.googlesource.com/c/go/+/533476
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
---

diff --git a/src/cmd/compile/internal/noder/writer.go b/src/cmd/compile/internal/noder/writer.go
index 6d7bd4c782..08da36eccb 100644
--- a/src/cmd/compile/internal/noder/writer.go
+++ b/src/cmd/compile/internal/noder/writer.go
@@ -1909,7 +1909,7 @@ func (w *writer) expr(expr syntax.Expr) {
 
 		var rtype types2.Type
 		if tv.IsBuiltin() {
-			switch obj, _ := lookupObj(w.p, expr.Fun); obj.Name() {
+			switch obj, _ := lookupObj(w.p, syntax.Unparen(expr.Fun)); obj.Name() {
 			case "make":
 				assert(len(expr.ArgList) >= 1)
 				assert(!expr.HasDots)
diff --git a/test/fixedbugs/issue63436.go b/test/fixedbugs/issue63436.go
new file mode 100644
index 0000000000..bbd34a5a28
--- /dev/null
+++ b/test/fixedbugs/issue63436.go
@@ -0,0 +1,9 @@
+// compile
+
+// Copyright 2023 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package p
+
+var _ = (new)(int)